Re: PATCH: include controlling language= in my previous patch

Hi Ihor,

thanks for the patience. I have a comment on the message you refer to... If comes from 2014.

So I have resorted to my fresh Emacs29, opened it with emacs -Q for a clean environment.

With the MWE

```

#+CAPTION: caption of block 1

#+BEGIN_SRC asm

vmpovapd %%zmm0, %zmm1

#+END_SRC

#+LABEL: lst:second

#+BEGIN_SRC asm

vmpovapd %%zmm0, %zmm1

#+END_SRC

# Local Variables:

# org-latex-listings: 'listings

# End:

```

I get the following:

```

\begin{lstlisting}[language=asm,label= ,caption={caption of block 1},captionpos=b,numbers=none]

vmpovapd %%zmm0, %zmm1

\end{lstlisting}

\begin{lstlisting}[language=asm,label=lst:org2f3fc09,caption= ,captionpos=b,numbers=none]

vmpovapd %%zmm0, %zmm1

\end{lstlisting}

```

In my most humble opinion, I looks like the global \lstset{} isn't used and that the caption/label is set locally. And this makes me believe that label= or caption= are not very useful.

I have extended my research to a SRC block without language and that results in a \begin{verbatim}--\end{verbatim}

I'm attaching the patch generated with git diff -p.

Mea culpa, I should have RTFM before sending anything :-)

Best, /PA

On Sun, 11 Dec 2022 at 11:05, Ihor Radchenko <yantar92@posteo.net> wrote:

Note: This email thread is a followup for CAO48Bk_6bqKgp1MgnZaARYku2+St6R1D4Bziq5NzMWNEWqfitw@mail.gmail.com" rel="noreferrer" target="_blank">https://orgmode.org/list/CAO48Bk_6bqKgp1MgnZaARYku2+St6R1D4Bziq5NzMWNEWqfitw@mail.gmail.com

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> I have a second version of my previous patch, inlcuing and extra variable
> to control whether you want to include the language= or not. It is made in
> a backwards-compatible way. Default is to include it and you have to
>
> (setq org-latex-listings-src-omit-language t)
>
> to omit language=

Makes sense from a first glance.

> + (when label ; label= w/o label makes little sense
> + `(("label" ,(org-latex--label src-block info))))
> + (when caption-str ; caption= w/o caption makes little sense
> + `(("caption" ,caption-str))
> + `(("captionpos" ,(if caption-above-p "t" "b")))) ; as does captionpos w/o caption

This is not true. We do need that empty caption/label.
See
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eaaa5c2e4
and
https://orgmode.org/list/534BEAFB.4080607@gmx.de

Also, if you can, please create a proper patch instead of diff. See
https://orgmode.org/worg/org-contribute.html#first-patch

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

From:	Pedro Andres Aranda Gutierrez
Subject:	Re: PATCH: include controlling language= in my previous patch
Date:	Sun, 11 Dec 2022 12:23:28 +0100