emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Possible bugs in org-babel-temp-stable-file (was: [PATCH] Add light argu


From: Ferdinand Pieper
Subject: Possible bugs in org-babel-temp-stable-file (was: [PATCH] Add light argument to org-babel-lob-get-info)
Date: Sat, 22 Oct 2022 17:28:01 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Ihor Radchenko <yantar92@posteo.net> writes:

> Applied onto main.

Thanks

> Have you seen org-babel-temp-stable-file?

I have not. Seems really useful, thanks for mentioning. I wrote my functions 
before org-babel-temp-stable-file was added, but seems I can simplify them now 
quite a bit.

I noticed two possible bugs in org-babel-temp-stable-file:

1. Prefix could be an empty string and that would break the filename extension, 
because (expand-file-name "" org-babel-temporary-stable-directory) would not 
add a slash in the path.

2. The org-babel-temporary-stable-directory is only created upon initial 
loading. But the intended behavior for remote paths seems to be to create the 
temp files on the remote. Which will fail, because 
org-babel-temporary-stable-directory does not exist on the remote. However 
creating the directories on remotes of course makes cleanup harder to 
impossible, if the remotes are not accessible any more.

I can try to write a patch for both, but I do not fully understand the 
org-babel-temp-stable-file code. It seems with the use of with-temp-file there 
is no need to change temporary-file-directory anymore?

It could also be nice to add an extra argument to force the use of the local 
org-babel-temporary-stable-directory for remote files.


Best,



reply via email to

[Prev in Thread] Current Thread [Next in Thread]