emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix void variable error `cider-buffer-ns` when specifying :b


From: Ihor Radchenko
Subject: Re: [PATCH] Fix void variable error `cider-buffer-ns` when specifying :backend header argument
Date: Wed, 12 Oct 2022 14:04:56 +0800

"Christopher M. Miles" <numbchild@gmail.com> writes:

> After updated to latest commit, I found error,
>
> Reproduce:
>
> When I specified the `:backend` header argument:
>
> #+begin_src clojure :backend babashka
> (+ 2 4)
> #+end_src
>
> I got error:
>
> #+begin_example
> void variable: cider-buffer-ns
> #+end_example

Thanks for reporting!

> Here is the patch fix upper issue.
>
>    (let* ((vars (org-babel--get-vars params))
> +         (backend-override (cdr (assq :backend params)))
>        (ns (or (cdr (assq :ns params))
> -              (if (eq org-babel-clojure-backend 'cider)
> +              (if (and (not backend-override)
> +                          (eq org-babel-clojure-backend 'cider))
>                    (or cider-buffer-ns
>                        (let ((repl-buf (cider-current-connection)))
>                          (and repl-buf (buffer-local-value

What if backend-override is 'cider?
I suggest to let-bind
(org-babel-clojure-backend
          (cond
           (backend-override (intern backend-override))
           (org-babel-clojure-backend org-babel-clojure-backend)
           (t (user-error "You need to customize `org-babel-clojure-backend'
or set the `:backend' header argument"))))

Just like in `org-babel-execute:clojure'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]