[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky age
|
From: |
Liu Hui |
|
Subject: |
Re: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky agenda |
|
Date: |
Thu, 06 Oct 2022 11:41:46 +0800 |
Ihor Radchenko <yantar92@gmail.com> writes:
>> +(defvar org-agenda-filters-preset nil
>> + "Preset of filters, which becomes buffer-local in org-agenda buffers.")
>
> Can you detail the value format in the docstring?
> It would also be useful to mention `org-agenda-local-vars'. Otherwise,
> the reader might be confused how `defvar' is buffer-local.
Done.
> Also, may you create a test for the reported bug in
> testing/lisp/test-org-agenda.el?
Done.
When writing the test, I find the original patch only addresses the
case where an entry contains multiple commands. Now the udpated patch
can address the case containing one command by changing another global
symbol property to per-buffer text property.
0001-Fix-filter-preset-problem-for-sticky-agenda.patch
Description: Text Data