Re: Please add support for dlangs packagemanager to ob-C.el

[tbanelwebmin]

    Thanks Christian.
    
    Your TINYCHANGE fits into the 15 lines limit. I
      will review it.
      
    As Bastien said, we follow as much as we can a predefined
      format for commit messages:
    https://orgmode.org/worg/org-contribute.html#commit-messages
    
    You may also look at past commit messages, for instance this
      one:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0a6a56c804099e358ca558119b7aede0b2b9b90f
    https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/
      
      If you want to further contribute, maybe in
      another TINYCHANGE, automatic unit tests are very valuable. There
      are already examples of Dlang tests in:
      testing/examples/ob-C-test.org
      testing/lisp/test-ob-C.el
      
      The best

Le 27/09/2022 à 22:41, Bastien a écrit :

> Hi Christian,
>
> thanks for the patch (you forgot to advertize it by adding [PATCH] in
> the subject.)
>
> Christian Köstlin <christian.koestlin@gmail.com> writes:
>
> > Please see the patch comment. I reworked my original patch to fit
> > into the TINYPATCH category.
> >       
> I'm CC'ing Thierry as the maintainer of ob-C.el.
>
> The commit message should be reworked - see
> https://orgmode.org/worg/org-contribute.html#commit-messages
>
> I would recommend not using source blocks in the message.
>
> I hope Thierry will have time to review it.
>
> Thanks!
>
>