emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] ol.el: add description format parameter to org-link-param


From: Max Nikulin
Subject: Re: [PATCH v3] ol.el: add description format parameter to org-link-parameters
Date: Tue, 21 Jun 2022 22:01:38 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 21/06/2022 19:03, Hugo Heagren wrote:
+(defmacro test-ol-with-link-parameters-as (type parameters &rest body)
[...]
+  `(progn
+     (setq orig-parameters org-link-parameters)

I can easily miss something, but wouldn't it be enough to use let-binding

`(let ((org-link-parameters org-link-parameters))
   ,@body)

Otherwise it is better to use something like `condition-case' to restore original state even when some error is signaled.

+     (org-link-set-parameters ,type ,@parameters)
+     (let ((rtn (progn ,@body)))
+       (setq org-link-parameters orig-parameters)
+       rtn)))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]