emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] ol.el: add description format parameter to org-link-param


From: Robert Pluim
Subject: Re: [PATCH v3] ol.el: add description format parameter to org-link-parameters
Date: Tue, 21 Jun 2022 15:41:07 +0200

>>>>> On Tue, 21 Jun 2022 13:03:32 +0100, Hugo Heagren <hugo@heagren.com> said:

    Hugo> They're very nearly just right, but for some reason
    Hugo> `test-ol-with-link-parameters-as' doesn't always reset the parameters
    Hugo> correctly for me. However I have them set to originally, it sets
    Hugo> `:default-description' to a lambda. This might be a quirk at my end
    Hugo> though -- if someone else could have a look I'd be very grateful.

They way your macro is defined, it uses `orig-parameters' in a way
that it will leak into the global namespace. Better would be to do

(let ((orig-parameters org-link-parameters))
       ...
      (setq org-link-parameters orig-parameters)

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]