Re: [BUG] org-save-all-org-buffers reapplies startup visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]

[Mark Barton]

 It works on my system with native compilation on macOS 11.6. I made the change 
to org.el that is in my local clone of the emacs master branch and recompiled.

Looking at the Help for the function, I see it is native compiled Lisp in my 
test here.

- *Help* - buffer
org-save-all-org-buffers is an interactive native compiled Lisp
function in ‘org.el’.

(org-save-all-org-buffers)
—

- diff -
Save all Org buffers without user confirmation.

modified   lisp/org/org.el
@@ -15362,7 +15362,7 @@ org-save-all-org-buffers
   "Save all Org buffers without user confirmation."
   (interactive)
   (message "Saving all Org buffers...")
-  (save-some-buffers t (lambda () (derived-mode-p 'org-mode)))
+  (save-some-buffers t (lambda () (and (derived-mode-p 'org-mode) t)))
   (when (featurep 'org-id) (org-id-locations-save))
   (message "Saving all Org buffers... done"))
 


> On Oct 9, 2021, at 9:38 AM, No Wayman <iarchivedmywholelife@gmail.com> wrote:
> 
> 
> Your analysis is correct. I looked into this a couple days ago.
> See the following message for an explanation and a patch (testing 
> appreciated):
> 
> 87zgrmc2rg.fsf@gmail.com/T/#m9888bc09d77d7bba70ba99671aca72446c4d41b9">https://list.orgmode.org/87zgrmc2rg.fsf@gmail.com/T/#m9888bc09d77d7bba70ba99671aca72446c4d41b9
> 
>