[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [BUG] 81c7a2dee8 misaligns time lines in agenda
From: |
Bastien |
Subject: |
Re: [BUG] 81c7a2dee8 misaligns time lines in agenda |
Date: |
Sat, 25 Sep 2021 21:46:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Adam,
Adam Porter <adam@alphapapa.net> writes:
> In the course of working on a PR for org-super-agenda [0], we found that
> a recent change to Org, commit 81c7a2dee8 [1], causes a misalignment in
> the way time lines in the agenda are displayed. The org-super-agenda
> test suite shows this change when results from Org 9.4 and 9.4.6 are
> compared. For example, in this diff of an agenda buffer:
>
> #+BEGIN_EXAMPLE diff
> @@ -2,8 +2,8 @@
> Wednesday 5 July 2017
>
> Today
> - test: 7:02...... Sunrise (12:04 of daylight)
> - 8:00...... ----------------
> + test: 7:02...... Sunrise (12:04 of daylight)
> + 8:00...... ----------------
> 10:00...... ----------------
> 12:00...... now - - - - - - - - - - - - - - - - - - - - - - -
> - -
> 12:00...... ----------------
> #+END_EXAMPLE
>
> The old lines, with single-digit hours, were properly aligned with the
> lines with multi-digit hours, but the new lines are one character too
> far to the left.
>
> Since Bastien made this change, and it's very simple, I'm guessing he'll
> know what the proper fix is. :)
The change I made was superceded by Nicolas series of patches:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/?qt=grep&q=fix+org-duration-to-minutes+error
I agree the new alignment looks wrong: the starting time should
bit right-aligned with other time above/below, and the separating
dash should not spaces for "HH:MM" time strings on the right, but
only for " H:MM".
Would you have time to prepare a patch for this?
- Re: [BUG] 81c7a2dee8 misaligns time lines in agenda,
Bastien <=