Re: [PATCH] org-plot abstractions and extension

[Kyle Meyer]

TEC writes:

> Kyle Meyer <kyle@kyleam.com> writes:
>
>> recent org-plot example from 8d5122fc5:
>> [...]
>> That could be rewritten as [...]
>
> Would you like me to bundle that change in somewhere?

In my view it's fine to leave it as is (it's just an example that was
fresh in my mind), but of course feel free to send a patch for it if
you'd like.

> One question, I saw Bastien say that we didn't want whitespace-only
> commits, so how should whitespace-fixups be done?

I think the idea is to avoid whitespace-only churn, particularly if the
only goal is tab/space indentation consistency.  In that case, you'd
just leave it be unless you're changing the code for some other reason.

On the other hand, I think a dedicated patch for the indentation fix you
had in the first commit would be welcomed.  The distinction is that in
this case the code is simply misaligned:

  (mapcar (lambda (row) (org--plot/values-stats
                    (mapcar #'string-to-number (cdr row))
                    hard-min
                    hard-max)) table)

I'd say that's worth fixing because it hurts readability.  Also, in the
process, it'd be good to move "table" to the next line because (to use
lisp-mode's phrasing) it's "hidden behind a deeper element".

> Subject: [PATCH] org-plot.el: fix compiler warnings

Thanks.  Applied (7a9a8a56a)...
>
> * lisp/org-plot.el (org--plot/values-stats): Replace `log10' with
> `log'.
> (org--plot/nice-frequency-pick): Replace obsolete `case' with `pcase`.

... with s/pcase/cl-case/ to match the final state of the code.