Re: [PATCH] org-plot abstractions and extension

[TEC]

Kyle Meyer <kyle@kyleam.com> writes:

> case is still available under the cl- prefix.  If you wanted to use it
> in 73c99bf42 (org-plot.el: add utility functions for range,ticks), I
> don't see a reason not to use it now.

I tend to use pcase over cl-case (since it's completely built in, i.e.
no (require 'cl-lib) required). I'm not sure if there's any argument for
cl-case over pcase, let me know if so.

> s/refence/reference/

Done

>> @@ -210,9 +210,9 @@ values, namely regarding the range."
>>    "From a the values in a TABLE of data, attempt to guess an appropriate 
>> number of ticks."
>>    (let* ((row-data
>>        (mapcar (lambda (row) (org--plot/values-stats
>> -                        (mapcar #'string-to-number (cdr row))
>> -                        hard-min
>> -                        hard-max)) table))
>> +                             (mapcar #'string-to-number (cdr row))
>> +                             hard-min
>> +                             hard-max)) table))
>
> Please drop this unrelated space change.

Erm, this isn't unrelated. As the function being called changed length,
the indentation of the arguments is thus also changed.

> The mapcar is unnecessary; you can reposition (lambda ...) as
> mapconcat's FUNCTION argument.

Thanks for spotting that. Resolved.

Updated patch attached. Let me know how it looks to you :)

--
Timothy

0001-org-plot.el-fix-compiler-warnings.patch
Description: Text Data