Re: [PATCH] org-add-planning-info: respect caller's given time [9.3.7 (release_9.3.7-716-g3d4876 @ /home/n/.emacs.d/straight/build/org/)]

[Kyle Meyer]

No Wayman writes:

> Unfortunately I'm unable to get the test suite to run correctly.
> I've followed the instructions in the testing/README, but the 
> tests hang due to some sort misconfiguration with python and 
> readline on my end:
>
>> Warning (python): Your ‘python-shell-interpreter’ doesn’t seem 
>> to
>> support readline, yet ‘python-shell-completion-native-enable’ 
>> was t
>> and "python" is not part of the
>> ‘python-shell-completion-native-disabled-interpreters’ list. 
>> Native
>> completions have been disabled locally.
>
> I'm running Emacs 28.0.5 on Arch linux. Searching for a solution, 
> but haven't come up with anything useful yet.
> I've tried adding (setq python-shell-completion-native-enable nil) 
> in the --eval program from the commandline,
> but this only silences the warning. Still hangs. I'll keep 
> reseraching.

Hmm, since 4df12ea39 (ob-python: Improve robustness of session
evaluation, 2020-09-06), the ob-python tests stall for me as well.

    $ make BTEST_RE='test-ob-python' test-dirty
    selected tests: test-ob-python
    Running 14 tests (2020-09-08 00:31:36-0400)
    Can’t guess python-indent-offset, using defaults: 4
    executing Python code block...
    Shell native completion is enabled.
    <hangs>

That's on a Debian system with the python executable pointing to Python
2.7.16.  If I set org-babel-python-command to python3 (3.7.3) at the top
of test-ob-python.el, I see the same thing.  I haven't dug any farther
yet.  Jack, presumably you don't see the stall on your end?

No Wayman, you could try running more targeted tests to get around the
stall.  For example, here's how to run just tests matching "test-org/".
In order to trigger the failure, I'm running it on the parent commit of
73a78c251 (Revert "org.el (org-add-planning-info): Use caller's
`org-time-was-given' value", 2020-09-06).

    $ make BTEST_RE='test-org/' test-dirty
    [...]
    Test test-org/org-read-date backtrace:
      signal(ert-test-failed (((should (equal "2012-03-30" (org-test-at-ti
      ert-fail(((should (equal "2012-03-30" (org-test-at-time "2012-03-29
      (if (unwind-protect (setq value-12923 (apply fn-12921 args-12922)) (
      (let (form-description-12925) (if (unwind-protect (setq value-12923
      (let ((value-12923 (quote ert-form-evaluation-aborted-12924))) (let
      (let* ((fn-12921 (function equal)) (args-12922 (condition-case err (
      (lambda nil (let* ((fn-12881 (function equal)) (args-12882 (conditio
      ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
      ert-run-test(#s(ert-test :name test-org/org-read-date :documentation
      ert-run-or-rerun-test(#s(ert--stats :selector "test-org/" :tests [#s
      ert-run-tests("test-org/" #f(compiled-function (event-type &rest eve
      ert-run-tests-batch("test-org/")
      ert-run-tests-batch-and-exit("test-org/")
      (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
      org-test-run-batch-tests("test-org/")
      eval((org-test-run-batch-tests org-test-select-re))
      command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
      command-line()
      normal-top-level()
    Test test-org/org-read-date condition:
        (ert-test-failed
         ((should
           (equal "2012-03-30"
                  (org-test-at-time "2012-03-29 16:40" ...)))
          :form
          (equal "2012-03-30" "2012-03-30 00:40")
          :value nil :explanation
          (arrays-of-different-length 10 16 "2012-03-30" "2012-03-30 00:40" 
first-mismatch-at 10)))
       FAILED   76/113  test-org/org-read-date
    [...]


As I mentioned in the message linked upstream, it doesn't happen when
running just test-org/org-read-date (BTEST_RE='test-org/org-read-date'),
so there's some sort of interaction between tests.