emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] allow for multiline headers


From: Nicolas Goaziou
Subject: Re: [PATCH] allow for multiline headers
Date: Mon, 29 Jun 2020 01:17:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello,

Mario Frasca <mario@anche.no> writes:

> On 24/06/2020 02:19, Nicolas Goaziou wrote:
>>
>>>> This could be extracted as an independent function, which would return
>>>> the header, or nil. We can also imagine a function returning a cons cell
>>>> (HEADER . BODY), both HEADER and BODY being list of rows (possibly
>>>> empty).
>>> I was thinking of this myself too.  but, after all, the goal of this
>>> function is not only to find the header, but to collapse it into
>>> a single line.
>> I suggested this because you were saying earlier in this thread IIRC
>> that Org has no tooling to handle table headers.
> I would like to discuss this in a chat, who's available to join
> #org-mode on freenode?

Note that, usually, discussions happen on this mailing list, so anyone
can comment, not only those available on the IRC channel at a given
time.

>>> if it was splitting the header from the body, then yes, it would
>>> definitely make sense, the cons cell you suggest.
>> It _is_ splitting the header from the body. Barring initial `hline'
>> symbols, header-lines and trailer variables are exactly HEADER and BODY
>> above.
> same as above, I wish to hear opinions, collect them, and that we take
> a decision with shorter communication lines.

I'm sorry if I'm not fast enough to answer. In any case, the above is
just a suggestion.

>>> +      (table (org-table-collapse-header (org-table-to-lisp)))
>>> +      (num-cols (length (car table))))
>> Note that there is no guarantee that all rows have the same length.
>> E.g.,
>>
>>    | a |
>>    | b | c |
>
> many other points in the code assume rows have the same length.

That's true. However, the above is still a correct table, so it is good
to keep it in mind. No worries if you don't want to take care of that
particular point.

> I think I have processed most other remarks in the new patch.

I applied your patch. Thank you.

Regards,
-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]