[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] org-protocol documentation
From: |
Mario Martelli |
Subject: |
Re: [O] org-protocol documentation |
Date: |
Fri, 23 Jun 2017 18:46:14 +0200 |
Hi,
> fails all the time causing the function to fail silently.
I got "open-source" working by sanitising the URI before it is processed.
diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index 825435674..7e986a9ed 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -520,7 +520,7 @@ The location for a browser's bookmark should look like this:
;; As we enter this function for a match on our protocol, the return value
;; defaults to nil.
(let ((result nil)
- (f (plist-get (org-protocol-parse-parameters fname nil '(:url)) :url)))
+ (f (org-protocol-sanitize-uri (plist-get (org-protocol-parse-parameters
fname nil '(:url)) :url))))
(catch 'result
(dolist (prolist org-protocol-project-alist)
(let* ((base-url (plist-get (cdr prolist) :base-url))
Unfortunately it is still failing for old-style URIs. Fixing that would exceed
my abilities.
I could document that "open-source" does only support new-style URIs. Not sure
if that is the best solution.
Kind regards
Mario
—
- Re: [O] org-protocol documentation, (continued)
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/19
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/19
- Re: [O] org-protocol documentation, Chunyang Xu, 2017/06/19
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/21
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/21
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/21
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/22
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/22
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/22
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/23
- Re: [O] org-protocol documentation,
Mario Martelli <=
- [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/25
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/25
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/25
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/26
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/27
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/28
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/28
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/28
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/29
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/29