[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fix clocktable scope parameter
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] Fix clocktable scope parameter |
Date: |
Thu, 15 Dec 2016 21:56:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hello,
Eduardo Bellani <address@hidden> writes:
> org-clock.el: Fix clocktable scope parameter
Thank you. However, this is not a "fix" per se.
> * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval
> the scope if it is a lisp expression, or to return the scope if it
> is just a list.
This comment is no longer accurate.
> + (function-name) @r{scan the list of files returned by calling
> this function.}
Why should the function be within a list? I suggest something like
function @r{list of files returned by calling the function with no argument}
> - ((pred consp) scope)
> + ((and (pred #'listp) (pred (lambda (scope) (symbolp (car
> scope)))))
> + (funcall (car scope)))
Per above, it should be
((pred functionp) (funcall scope))
Regards,
--
Nicolas Goaziou
- [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Thomas S. Dye, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter,
Nicolas Goaziou <=
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15