[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fix clocktable scope parameter
From: |
Eduardo Bellani |
Subject: |
Re: [O] [PATCH] Fix clocktable scope parameter |
Date: |
Thu, 15 Dec 2016 13:31:45 -0200 |
User-agent: |
mu4e 0.9.17; emacs 24.4.1 |
Hello Nicolas,
I agree with you about introducing 'eval' into the code base. This was
just me getting the code from 8.3 back in a format the current code
understand. Which leads me to conclude that this is not new
functionality, just old undocumented functionality. I've found out about
it through this SE post: http://emacs.stackexchange.com/a/7903
Anyway, I'll modify the patch and include documentation for this
functionality.
Nicolas Goaziou writes:
> Hello,
>
> Eduardo Bellani <address@hidden> writes:
>
>> org-clock.el: Fix clocktable scope parameter
>>
>> * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval
>> the scope if it is a lisp expression, or to return the scope if it
>> is just a list.
>>
>> This adds back to the clocktable the capacity to have as scope both a
>> list of file paths or a function that returns such a list.
>
> Thank you.
>
> However, I'd rather not introduce more `eval' in the code base.
>
> Instead, you can test if scope is a function and `funcall' it. This is
> a new feature, which would require some documentation and an entry in
> ORG-NEWS.
>
> Regards,
signature.asc
Description: PGP signature
- [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter,
Eduardo Bellani <=
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Thomas S. Dye, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15