emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Problems with (defvar foo) and Emacs 23


From: Achim Gratz
Subject: Re: [O] Problems with (defvar foo) and Emacs 23
Date: Mon, 02 Apr 2012 07:31:34 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)

Nick Dokos writes:
> I assume that we are talking about the seven commits

Yes, but likely not all of them (or all changes in them).  The only
problematic ones are where a dynamically scoped variable is renamed and
there are a bunch of others that probably are OK.

> $ git log --oneline -100 | grep 'Fix global'
> 6cbf1f4 Fix global dynamic variables in org-agenda.el and org.el.
> b689cbf Fix global dynamic variables in org-table.el.
> 9054ba3 Fix global dynamic variables in org-special-blocks.el.
> b46fa17 Fix global dynamic variables in org-clock.el.
> 08d9b46 Fix global dynamic variables prefixes in org-bibtex.el.
> c24fa19 Fix global dynamic variables prefixes in org-mouse.el.
> fcf13e0 Fix global dynamic variables prefixes in org-beamer.el.
>
> I tried reverting these in a branch: I had to merge lisp/org.el by hand
> while reverting the first one, but the rest went through without any
> problems.
>
> Does that seem like the right thing to do for now then?

For Emacs 24, it is probably the right thing to do, depending on how
much time there is left before release.  In hotfix/master the changes
should be corrected so that they do what they were supposed to do
(i.e. also rename the variables in the caller).


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables




reply via email to

[Prev in Thread] Current Thread [Next in Thread]