master c18bfbe: Improve ffap-ido-mode test

[Lars Ingebrigtsen]

branch: master
commit c18bfbe6e452bfbef276fc8325bdbfc6c7e0d61b
Author: dickmao <none>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Improve ffap-ido-mode test
    
    * test/lisp/ffap-tests.el (ffap-ido-mode): Actually test
    `ido-everywhere' at run time, not compile time (bug#49895).
---
 test/lisp/ffap-tests.el | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/test/lisp/ffap-tests.el b/test/lisp/ffap-tests.el
index 4fb4c90..f8113bf 100644
--- a/test/lisp/ffap-tests.el
+++ b/test/lisp/ffap-tests.el
@@ -127,13 +127,17 @@ left alone when opening a URL in an external browser."
   (require 'ido)
   (with-temp-buffer
     (let ((ido-mode t)
-          (read-filename-function read-file-name-function)
+          (read-file-name-function read-file-name-function)
           (read-buffer-function read-buffer-function))
-      (ido-everywhere)
+      ;; Says ert-deftest:
+      ;; Macros in BODY are expanded when the test is defined, not when it
+      ;; is run.  If a macro (possibly with side effects) is to be tested,
+      ;; it has to be wrapped in `(eval (quote ...))'.
+      (eval (quote (ido-everywhere)))
       (let ((read-file-name-function (lambda (&rest args)
-                                     (expand-file-name
-                                      (nth 4 args)
-                                      (nth 1 args)))))
+                                       (expand-file-name
+                                        (nth 4 args)
+                                        (nth 1 args)))))
         (save-excursion (insert "ffap-tests.el"))
         (let (kill-buffer-query-functions)
           (kill-buffer (call-interactively #'find-file-at-point)))))))