Re: Please check if GPM works as expected

[Eli Zaretskii]

> Date: Sat, 25 Jan 2025 21:15:32 -0800
> From: Jared Finder <jared@finder.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> On 2025-01-25 09:13, Gerd Möllmann wrote:
> > Jared Finder <jared@finder.org> writes:
> > 
> >>> Sorry for that. Tried with the buttons in *Help*, and that works for
> >>> me
> >>> with xt-mouse.el. Can you please tell me what you did? Maybe I broke
> >>> something special. Or maybe the change I did in xt-mpuse.el is a 
> >>> hint?
> >> 
> >> xterm mouse is fine with clickable text. The issue is only with gpm
> >> mouse.  I'm guessing some change in xt-mouse.el didn't properly get
> >> mirrored over to handle_one_term_event in term.c.
> > 
> > Okay, thanks!
> 
> Adding event.x = gpm_x; event.y = gpm_y after the call to tty_frame_at 
> fixes this.
> 
> Eli, is there an intentional reason the values of gpm_x and gpm_y are 
> not copied back into event.x and event.y in commit e8f173?

Just the fact that I don't understand the GPM code well enough.

> Assuming this was just a mistake, perhaps it would make sense to alter 
> tty_frame_at to take short int as parameters instead of int (with a bit 
> of additional error checking, of course).  An int is already truncating 
> some fixnum values and I can't imagine a TTY with more than 16000 rows 
> or columns.

I wouldn't switch to shorts, as shorts are less natural than ints.
Explicitly copying the values in a couple of places is a no-brainer.