emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The Android port and the Emacs web page


From: Eli Zaretskii
Subject: Re: The Android port and the Emacs web page
Date: Sat, 25 Jan 2025 10:40:03 +0200

> From: Po Lu <luangruo@yahoo.com>
> Cc: Philip Kaludercic <philipk@posteo.net>,  emacs-devel@gnu.org
> Date: Sat, 25 Jan 2025 08:59:56 +0800
> 
> Peter Oliver <p.d.oliver@mavit.org.uk> writes:
> 
> > On Sun, 19 Jan 2025, Peter Oliver wrote:
> >
> >> Currently, this is hard-coded to 30 in java/AndroidManifest.xml.in, but 
> >> something like 300093000 would be needed (for 30.0.93).  Could we set that 
> >> for them?
> >
> > In other words,
> >
> > diff --git a/admin/admin.el b/admin/admin.el
> > index d98b8243f25..57335f95d3a 100644
> > --- a/admin/admin.el
> > +++ b/admin/admin.el
> > @@ -116,6 +116,13 @@ set-version
> >                         (rx (and "AC_INIT" (1+ (not (in ?,)))
> >                                   ?, (0+ space) ?\[
> >                                   (submatch (1+ (in "0-9."))))))
> > +  (set-version-in-file root "java/AndroidManifest.xml.in"
> > +                       (apply #'format "%02d%02d%02d000"
> > +                              (mapcar #'string-to-number
> > +                                      (split-string version "\\.")))
> > +                      (rx (and "android:versionCode=\""
> > +                                (submatch (1+ (in digit)))
> > +                                "\"")))
> >     (set-version-in-file root "nt/README.W32" version
> >                         (rx (and "version" (1+ space)
> >                                  (submatch (1+ (in "0-9."))))))
> 
> Once the versionCode property is increased, upgraded installations
> cannot be downgraded to previous Emacs releases, and on this account I
> am not very ready to agree to such a change.

But at some point, we'd need to bump that from 30, no?  Or are you
saying this will always be left at 30?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]