Re: [PATCH] Fix mouse click on flymake

[Juri Linkov]

> Flymake with fringe indicator supports an action to click in the fringe
> and show the buffer diagnostics.
>
> This was only working on gui just because the map action was not
> set. Not sure if that was intended.

No, this was not intended.

> The attached patch attempts to fix that; If you thing it is correct,
> please, push it.

Thanks.

>  (defvar flymake-mode-map
>    (let ((map (make-sparse-keymap)))
> -    (define-key map `[,flymake-fringe-indicator-position mouse-1]
> +    (define-key map `[,(pcase flymake-indicator-type
> +                      ('fringes flymake-fringe-indicator-position)
> +                      ('margins flymake-margin-indicator-position))
> +                      mouse-1]

What would happen when the user changes the value of flymake-indicator-type?
The keybinding is not updated?  What if the value is nil?
Maybe better to bind both 'fringes' and 'margins'?
Or update keybindings when flymake-indicator-type is customized?