Re: [PATCH] Fix mouse click on flymake

[Eli Zaretskii]

> Date: Sun, 19 Jan 2025 03:24:23 +0100
> From: Ergus <spacibba@aol.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> Flymake with fringe indicator supports an action to click in the fringe
> and show the buffer diagnostics.
> 
> This was only working on gui just because the map action was not
> set. Not sure if that was intended.
> 
> The attached patch attempts to fix that; If you thing it is correct,
> please, push it.

> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
> index 9dda53713f5..9404548aa8c 100644
> --- a/lisp/progmodes/flymake.el
> +++ b/lisp/progmodes/flymake.el
> @@ -1371,7 +1371,10 @@ flymake-start
>  
>  (defvar flymake-mode-map
>    (let ((map (make-sparse-keymap)))
> -    (define-key map `[,flymake-fringe-indicator-position mouse-1]
> +    (define-key map `[,(pcase flymake-indicator-type
> +                      ('fringes flymake-fringe-indicator-position)
> +                      ('margins flymake-margin-indicator-position))
> +                      mouse-1]
>                  #'flymake-show-buffer-diagnostics)
>      map)
>    "Keymap for `flymake-mode'.")

Spencer, any comments?