Re: Merging scratch/no-purespace to remove unexec and purespace

[Andrea Corallo]

Pip Cet <pipcet@protonmail.com> writes:

> "Andrea Corallo" <acorallo@gnu.org> writes:
>
>>> commit a0abd3033414a011125e815d30890ed22b80a84e (HEAD)
>>> Author: Pip Cet <pipcet@protonmail.com>
>>> Date:   Tue Jan 7 12:13:40 2025 +0000
>>>
>>>     Use #$ for lambda fixups in native compilation data vectors
>>>
>>>     * lisp/emacs-lisp/comp.el (comp--#$): New defvar.
>>>     (comp--finalize-container): Use it.
>>>     * src/comp.c (ABI_VERSION): Bump.
>>>     (emit_static_object): Ensure 'comp--#$' prints as "#$".
>>>     (load_static_obj): Ensure '#$' reads as Vcomp__hashdollar.
>>>     (check_comp_unit_relocs): Adjust assertion.
>>>     (syms_of_comp): Define 'comp--#$'.
>>>     * src/pdumper.c (dump_do_dump_relocation): Adjust assertion.
>>
>> The code LGTM, I'd only expand the commit message with a quick
>> explaination of the mechanism and a link to this discussion.
>
> I tried to, but the relevant message never made it to the emacs-devel
> archives, it seems.  Is this a known issue?

Not to me at least :(

>>> +  specpdl_ref count = SPECPDL_INDEX ();
>>>    static_obj_t *blob =
>>>      dynlib_sym (comp_u->handle, format_string ("%s_blob", name));
>>> +  /* Special value so we can recognize #$.  */
>>
>> Probably this comment should be a little more generous.
>
> Agreed.
>
>> Otherwise okay for me for scratch/no-purespace.
>
> I'll push without the link in a bit, unless we find a solution for that
> problem.

Okay, with some explaination in the comment + commit message is
sufficient.

Thanks

  Andrea