emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Refactor elpa/oauth2.el to use plist over cl-defstruct


From: Stefan Kangas
Subject: Re: Refactor elpa/oauth2.el to use plist over cl-defstruct
Date: Tue, 14 Jan 2025 13:23:16 -0600

Soham Gumaste <sohamg2@gmail.com> writes:

> Hello,
>
> I have some more free time so I was looking into my oauth2.el again. I
> want to ask if it would be desirable to refactor the library to use
> plists in place of `cl-defstruct`? This would make more sense as the
> storage backend used is plstore, which uses plists as its native format.

I'm copying in some people who might have an opinion about that.

> I have also read that the use of cl-lib is discouraged for various reasons.

We leave it up to individual authors to decide whether or not to use it,
based on what they find useful, their personal preferences, etc.

In other words, there is no need to remove `cl-lib` just for the sake of
removing `cl-lib`, so I would only bother if it helps for other reasons.

> My overall goal is to make oauth2.el integrate with auth-sources, and
> properly hook into functions like `auth-info-password` to refresh (if
> needed) and supply the token, in hopes to better integrate with nnimap
> in gnus.el.

That sounds like a it would be useful.  Thanks.

> Please let me know if you have any opinions on this. Please CC my email
> as I consume this list in digest form.
>
>
> Thanks,
> Soham
> sohamg2@gmail.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]