[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: "Final" version of tty child frames
From: |
martin rudalics |
Subject: |
Re: "Final" version of tty child frames |
Date: |
Sat, 11 Jan 2025 16:55:50 +0100 |
User-agent: |
Mozilla Thunderbird |
>> LGTM, please apply.
>
> Now installed on the master branch, thanks.
This was supposedly posted in the wrong sub-thread.
It gives me here
../../src/term.c: In function ‘tty_frame_at’:
../../src/term.c:2600:68: error: invalid operands to binary != (have
‘Lisp_Object’ and ‘Lisp_Object’)
2600 | for (Lisp_Object frames = Ftty_frame_list_z_order (Qnil); frames !=
Qnil;
| ^~
And while we're here please avoid idioms like
if (! FRAMEP (last_mouse_frame))
return;
*fp = XFRAME (last_mouse_frame);
since we just had a quite similar bug elsewhere. As a rule, always
write
if (!FRAMEP (last_mouse_frame)
|| !FRAME_LIVE_P (XFRAME (last_mouse_frame)))
return;
Thanks, martin
- Re: "Final" version of tty child frames, (continued)
Re: "Final" version of tty child frames, Jared Finder, 2025/01/04
- Re: "Final" version of tty child frames, Gerd Möllmann, 2025/01/04
- Re: "Final" version of tty child frames, Eli Zaretskii, 2025/01/05
- Re: "Final" version of tty child frames, Jared Finder, 2025/01/05
- Re: "Final" version of tty child frames, Gerd Möllmann, 2025/01/05
- Re: "Final" version of tty child frames, Eli Zaretskii, 2025/01/06
- Re: "Final" version of tty child frames, Jared Finder, 2025/01/07
- Re: "Final" version of tty child frames, Gerd Möllmann, 2025/01/07