Re: New "make benchmark" target

[Stefan Kangas]

Pip Cet <pipcet@protonmail.com> writes:

> Pushed to scratch/elisp-benchmarks.  Sorry for all the noise; we should
> really find a way to reduce emacs-diffs notifications when many commits
> are made at once.

Thanks.

AFAIU, the purpose of the emacs-diffs list is to detail the full history
of all commits.  We have enough disk and bandwidth these days, and
threads are easy to skip, so I wouldn't worry about it.

>>> My preference would be a top-level directory called "elisp-benchmarks",
>>> but ultimately that's a minor question, so just let me know the
>>> preferred destination.
>>
>> I thought we wanted it under test/ ?
>>
>> But I'm also okay with having a directory that is sibling to test/ if
>> there are no objections from Andrea and others.
>
> Obviously, it's not too late for such objections.  That's why I wanted
> to include the script: redoing the merge that way is much easier than
> applying git filter-repo to a "live" Emacs repo (which is destroyed in
> the process).

My two cents:

I'd put this in a directory named "benchmarks" instead.  The "elisp-"
part is relevant only because that was the name of the old GNU ELPA
package, but seems redundant as part of a directory name in emacs.git.
We also don't have "elisp-src" and "elisp-test", for example.