Re: Prefer to split along the longest edge

[Eli Zaretskii]

> From: Nicolas Desprès <nicolas.despres@gmail.com>
> Date: Tue, 17 Dec 2024 07:06:07 +0100
> Cc: juri@linkov.net, emacs-devel@gnu.org
> 
> I have attached a new patch that should address all your remarks.

Thanks.

> @@ -519,7 +520,9 @@ Window Choice
>  @code{split-width-threshold} is smaller than the window's width, the
>  split puts the new window on the right.  If neither condition holds,
>  Emacs tries to split so that the new window is below---but only if the
> -window was not split before (to avoid excessive splitting).
> +window was not split before (to avoid excessive splitting). Whether
                                                             ^^
Our convention is to leave two spaces between sentences.  (The same is
true for the text in the commit log messages.)

> ++++
> +*** New user option 'preferred-split-edge'.
> +Users can now choose which edge (vertical or horizontal) is tried to be
> +split first.  With this new setting, when the frame is in landscape shape
> +for instance, Emacs could split horizontally before to split vertically.

This should say what is the default behavior.

> +(defcustom preferred-split-edge 'vertical
> +  "The edge that `split-window-sensibly' will try to split first.
> +This order matter when both edges can be split according to
> +`split-width-threshold' and `split-height-threshold'."

This doc string should explain the meaning of each value.  (Yes, I
know that the text which describes each option does, but that doesn't
help when the user reads the doc string shown by "C-h v", for
example.)

> +  :type '(choice
> +          (const :tag "Try to split vertically first (legacy behavior)"
> +                 vertical)
> +          (const :tag "Try to split horizontally first"
> +                 horizontal)
> +          (const :tag "Try to split along the longest edge first"
> +                 longest))
> +  :version "30.1"
     ^^^^^^^^^^^^^^
This should be "31.1".