emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [NonGNU ELPA] new package: eglot-inactive-regions


From: Filippo Argiolas
Subject: Re: [NonGNU ELPA] new package: eglot-inactive-regions
Date: Wed, 04 Dec 2024 21:59:40 +0100

Filippo Argiolas <filippo.argiolas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> I would try something of the form like
>>
>>   (if (fboundp 'new-function)
>>       (new-function ...)
>>     (old-function ...))
>>
>> If on the other hand there has already been a new release of Eglot with
>> these commands, then just depend on that version and the issue would
>> resolve itself.
>>
>
> CC-ing João.
>
> I pushed the suggested change but I still get the compile warnings about
> deprecated functions. I'd like to keep supporting emacs-29, should I
> just disregard the warning?
>
> Sorry for the ignorance, how would the dependency on a specific eglot
> version work now that it's in core?
> Does it require the users to have additional repos enabled?
>
> Sounds strange to me that we have macros to deprecate functions but no
> mechanism to automatically switch to the new one if it's just a
> rename. Am I missing something obvious?
>
> Thanks!
>
> Filippo

How about something like:

  ;; fallback to deprecated eglot functions
  (when (version< emacs-version "30")
    (defalias 'eglot-uri-to-path 'eglot--uri-to-path)
    (defalias 'eglot-range-region 'eglot--range-region))

or even something similar with a check on eglot version?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]