Re: emacs-30 7c50e4cc8cc 2/2: Improve 'compilation-transform-file-match-alist' documentation

[Robert Pluim]

>>>>> On Wed, 04 Dec 2024 16:56:04 +0200, Eli Zaretskii <eliz@gnu.org> said:

    Eli> I don't think I'd mind to install on emacs-30, but if we are doing
    Eli> this, why not do a better job?  The tags above are not quite clear, to
    Eli> say the least.  "Match"? "Replace with"? does that really explain
    Eli> itself?

The docstring is supposed to explain it :-) How about:

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index ee7fc6aaecb..99385fcca07 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -77,8 +77,9 @@ compilation-transform-file-match-alist
 Similarly, to remove a prefix \"bar/\", use:
 
     (\"\\\\=`bar/\" \"\")"
-  :type '(repeat (list regexp (choice (const :tag "No replacement" nil)
-                                      string)))
+  :type '(repeat (list (regexp :tag "Match filename(s)")
+                       (radio (const :tag "Not an error" nil)
+                              (string :tag "Replace match with"))))
   :version "27.1")
 
 (defvar compilation-filter-hook nil

Robert
--