Re: emacs-30 7c50e4cc8cc 2/2: Improve 'compilation-transform-file-match-alist' documentation

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 04 Dec 2024 15:25:08 +0100
> 
> >>>>> On Wed,  4 Dec 2024 09:20:55 -0500 (EST), Robert Pluim 
> >>>>> <rpluim@gmail.com> said:
> 
>     Robert>    :type '(repeat (list regexp (choice (const :tag "No 
> replacement" nil)
>     Robert>                                        string)))
>     Robert>    :version "27.1")
> 
> I almost did the following as well on emacs-30, on the grounds that it
> doesnʼt actually affect the real type of the user option, only the
> display, but since I wasnʼt sure that was OK for the release branch I
> thought Iʼd ask here.
> 
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index ee7fc6aaecb..6a640a3c056 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -77,8 +77,9 @@ compilation-transform-file-match-alist
>  Similarly, to remove a prefix \"bar/\", use:
>  
>      (\"\\\\=`bar/\" \"\")"
> -  :type '(repeat (list regexp (choice (const :tag "No replacement" nil)
> -                                      string)))
> +  :type '(repeat (list (regexp :tag "Match")
> +                       (radio (const :tag "Not an error" nil)
> +                              (string :tag "Replace with"))))
>    :version "27.1")

I don't think I'd mind to install on emacs-30, but if we are doing
this, why not do a better job?  The tags above are not quite clear, to
say the least.  "Match"? "Replace with"? does that really explain
itself?

Thanks.