Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Pip Cet]

On Tuesday, July 9th, 2024 at 14:16, Po Lu <luangruo@yahoo.com> wrote:
> Andrea Corallo acorallo@gnu.org writes:
> > Pip Cet pipcet@protonmail.com writes:
> > 
> > > On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo acorallo@gnu.org 
> > > wrote:
> > > 
> > > > Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes:
> > > > 
> > > > > branch: scratch/igc
> > > > > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
> > > > > Author: Pip Cet pipcet@protonmail.com
> > > > > Commit: Pip Cet pipcet@protonmail.com
> > > > > 
> > > > > Fix GTK-related MPS crashes
> > > > > 
> > > > > * src/gtkutil.c (free_glib_user_data): New function.
> > > > > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
> > > > > (qttip_cb, xg_create_frame_widgets)
> > > > > (xg_create_frame_outer_widgets, create_dialog)
> > > > > (make_cl_data, unref_cl_data, xg_mark_data)
> > > > > (menuitem_highlight_callback, xg_create_one_menuitem)
> > > > > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
> > > > > (draw_page, xg_print_frames_dialog, xg_create_toolbar)
> > > > > (xg_im_context_commit, xg_widget_style_updated)
> > > > > (tb_size_cb): Adjust to use `get_glib_user_data' and` 
> > > > > g_signal_connect_data'.
> > > > > (xg_initialize): Remove linked list if HAVE_MPS.
> > > > > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
> > > > > functions.
> > > > > * src/xmenu.c (menubar_selection_callback)
> > > > > (popup_selection_callback): Adjust to use `get_glib_user_data'.
> > > > 
> > > > Hello,
> > > > 
> > > > as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
> > > > G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
> > > > following on my system:
> > > 
> > > Thank you! Can you let me know which gtk/glib version that is? I'd
> > > like to check the source code to make sure we can pass the right
> > > flag instead.
> > > 
> > > I think we're okay just passing 0 instead.
> > > 
> > > Pip
> > 
> > Should be GTK 3.24.33 and glib 2.0.
> 
> 
> Passing 0 is correct.

Thank you both, just pushed a fix. Please let me know if it isn't working.

Pip