Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Andrea Corallo]

Pip Cet via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> branch: scratch/igc
> commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
> Author: Pip Cet <pipcet@protonmail.com>
> Commit: Pip Cet <pipcet@protonmail.com>
>
>     Fix GTK-related MPS crashes
>
>     * src/gtkutil.c (free_glib_user_data): New function.
>     (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
>     (qttip_cb, xg_create_frame_widgets)
>     (xg_create_frame_outer_widgets, create_dialog)
>     (make_cl_data, unref_cl_data, xg_mark_data)
>     (menuitem_highlight_callback, xg_create_one_menuitem)
>     (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
>     (draw_page, xg_print_frames_dialog, xg_create_toolbar)
>     (xg_im_context_commit, xg_widget_style_updated)
>     (tb_size_cb): Adjust to use `get_glib_user_data' and
>     `g_signal_connect_data'.
>     (xg_initialize): Remove linked list if HAVE_MPS.
>     * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
>     functions.
>     * src/xmenu.c (menubar_selection_callback)
>     (popup_selection_callback): Adjust to use `get_glib_user_data'.

Hello,

as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
following on my system:

  CC       gtkutil.o
gtkutil.c: In function ‘qttip_cb’:
gtkutil.c:902:30: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
  902 |                              G_CONNECT_DEFAULT);
      |                              ^~~~~~~~~~~~~~~~~
gtkutil.c:902:30: note: each undeclared identifier is reported only once for 
each function it appears in
gtkutil.c: In function ‘xg_create_frame_widgets’:
gtkutil.c:1579:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 1579 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘create_dialog’:
gtkutil.c:2406:36: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 2406 |                                    G_CONNECT_DEFAULT);
      |                                    ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_create_one_menuitem’:
gtkutil.c:3336:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 3336 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘create_menus’:
gtkutil.c:3455:30: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 3455 |                              G_CONNECT_DEFAULT);
      |                              ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_update_menu_item’:
gtkutil.c:3931:40: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 3931 |                                        G_CONNECT_DEFAULT);
      |                                        ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_update_frame_menubar’:
gtkutil.c:4211:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 4211 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_print_frames_dialog’:
gtkutil.c:5317:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 5317 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_create_tool_bar’:
gtkutil.c:5595:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this 
function)
 5595 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~

Thanks

  Andrea