emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Start of Emacs 30 release cycle


From: Robert Pluim
Subject: Re: Start of Emacs 30 release cycle
Date: Tue, 25 Jun 2024 17:09:48 +0200

>>>>> On Tue, 25 Jun 2024 16:48:43 +0200, Stephen Berman 
>>>>> <stephen.berman@gmx.net> said:

    Stephen> On Tue, 25 Jun 2024 16:10:30 +0200 Robert Pluim <rpluim@gmail.com> 
wrote:
    >>>>>>> On Tue, 25 Jun 2024 12:41:02 +0200, Stephen Berman
    >> <stephen.berman@gmx.net> said:
    Stephen> Yes, indeed.  Is the attached complete patch ready to install in
    Stephen> emacs-30?
    >> 
    >> Minor comments below (although globally Iʼd say youʼre overriding the
    >> .dir-locals.el setting for `indent-tabs-mode', which is why the diffs
    >> look funny)

    Stephen> I haven't changed indent-tabs-mode: its global value is the 
default t
    Stephen> but in buffers under emacs/lisp nil.  And the diffs don't look 
funny to
    Stephen> me; how do they look funny to you?

eg this hunk:

 (defsubst widget-type (widget)
@@ -2452,10 +2475,16 @@ 'checkbox
 (defun widget-checkbox-action (widget &optional event)
   "Toggle checkbox, notify parent, and set active state of sibling."
   (widget-toggle-action widget event)
-  (let ((sibling (widget-get-sibling widget)))
+  (let* ((sibling (widget-get-sibling widget))
+         (from (widget-get sibling :from))
+        (to (widget-get sibling :to)))

Thereʼs a tab on the line for 'to', but the line for 'from' uses spaces.

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]