emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Submitting Dslide to Non-GNU ELPA


From: Psionic K
Subject: Re: Submitting Dslide to Non-GNU ELPA
Date: Fri, 21 Jun 2024 22:42:26 +0900

I pushed updates.  I declined two changes and wanted to point them out:

>  (defun dslide--list-item-contains (item loc)
> -  (when item
> -    (let ((beg (car item))
> -          (end (car (last item))))
> -      (and  (>= loc beg)
> -            (< loc end)))))
> +  (and item (<= (car item) loc (+ (car (last item))))))

I omitted the call to `+'.  No idea what it could do there.  `item' is an org item, which will always contain an integer in this situation.

I did not use `message--max' because it produced a compiler warning.

If either of these are still recommended, just let me know.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]