emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Treesit says grammar is unavailable when it


From: Eli Zaretskii
Subject: Re: Treesit says grammar is unavailable when it
Date: Thu, 14 Dec 2023 10:27:30 +0200

> From: Yuan Fu <casouri@gmail.com>
> Date: Thu, 14 Dec 2023 00:14:01 -0800
> Cc: gernotk@gmail.com,
>  emacs-devel@gnu.org
> 
> >> Thanks for sharing this! Eli, this sort of thing might be good reasons 
> >> to also print the error message from ldopen, rather than simply saying 
> >> not found?
> > 
> > I don't mind, but IME relying too much on these error messages is not
> > always a good idea, since sometimes they are too generic and say
> > nothing except "this failed".  But if it will help in some cases,
> > let's do it.
> > 
> > However, I would like to see the patch, since we seem to be signaling
> > an error already, and the error includes the error message from
> > dynlib_open?  So what am I missing?
> 
> We were showing error messages from dlopen, and then removed them for 
> brevity, see e8df6c311fcf59bf23d31b9db2bb8fec9d78fbe7

If these messages are useful, we can revert that commit.

> Maybe we can fold the extra error messages by default?

I'm not sure I understand the details, but the idea is certainly okay.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]