Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded.

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > IOW, merge `insert-directory` and `ls-lisp--insert-directory`
  > by allowing `insert-directory-program` to be nil
  > (as a replacement for the `ls-lisp-use-insert-directory-program`
  > boolean) in which case we use the ls-lisp code?

That is a good change to make.  For parts of Emacs to put advice on
functions in Emacs is asking for confusion in future debugging,
because there is no clue in the advised functions that advice might be
on them.

With this change, the use of the variable `insert-directory-program'
will show people that they should check that variable's value to see
what is really going on!



-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)