emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when l


From: Stefan Monnier
Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded.
Date: Wed, 06 Dec 2023 16:32:51 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

> If that can be done safely and cleanly, yes.

I'll see what I can come up with.

> But then I wonder why we decided to use advice all those years ago...

Originally, the ls-lisp code did a flat-out override of
`insert-directory`, so using an advice was cleaner than what we
had before.

But I guess I didn't realize back then that `ls-lisp.el` is preloaded in
W32 builds (and also: we still used advice in a few other preloaded
packages, such as uniquify).
Now that it's the last preloaded use of advice, ...


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]