[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] externals/standard-themes 0604883ecc: Expand 'deftheme' with
From: |
Philip Kaludercic |
Subject: |
Re: [elpa] externals/standard-themes 0604883ecc: Expand 'deftheme' with metadata |
Date: |
Fri, 25 Aug 2023 07:43:55 +0000 |
ELPA Syncer <elpasync@gnu.org> writes:
> branch: externals/standard-themes
> commit 0604883ecc89f37f2d8fcb33ec3c8f7f2b8bbe2e
> Author: Protesilaos Stavrou <info@protesilaos.com>
> Commit: Protesilaos Stavrou <info@protesilaos.com>
>
> Expand 'deftheme' with metadata
>
> This is to support new features in Emacs where themes can specify
> the set they belong to, as well as whether they are light or dark.
> The built-in command is 'theme-choose-variant'.
>
> This is in response to Emacs bug#65468:
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65468>. Thanks to
> Mauro Aranda for bringing this matter to my attention.
> ---
> standard-dark-theme.el | 9 +++++----
> standard-light-theme.el | 9 +++++----
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/standard-dark-theme.el b/standard-dark-theme.el
> index 726e888915..cf863c7fa4 100644
> --- a/standard-dark-theme.el
> +++ b/standard-dark-theme.el
> @@ -40,8 +40,12 @@
> (eval-and-compile
> (require 'standard-themes)
>
> +;;;###theme-autoload
> (deftheme standard-dark
> - "Like the unthemed dark Emacs, but more consistent.")
> + "Like the unthemed dark Emacs, but more consistent."
> + :background-mode 'dark
> + :kind 'color-scheme
> + :family 'standard)
Please note that this will cause an issue for anyone using the package
before Emacs 29, because deftheme only accepts 1-2 arguments before
da2e6da72296.
> (defconst standard-dark-palette
> '(;; Basic tones
> @@ -246,7 +250,4 @@ represents."
>
> (provide-theme 'standard-dark))
>
> -;;;###theme-autoload
> -(put 'standard-dark 'theme-properties '(:background-mode dark :kind
> color-scheme :family standard))
> -
> ;;; standard-dark-theme.el ends here
> diff --git a/standard-light-theme.el b/standard-light-theme.el
> index 3c7e518548..a4fcf16b82 100644
> --- a/standard-light-theme.el
> +++ b/standard-light-theme.el
> @@ -40,8 +40,12 @@
> (eval-and-compile
> (require 'standard-themes)
>
> +;;;###theme-autoload
> (deftheme standard-light
> - "Like the unthemed light Emacs, but more consistent.")
> + "Like the unthemed light Emacs, but more consistent."
> + :background-mode 'light
> + :kind 'color-scheme
> + :family 'standard)
>
> (defconst standard-light-palette
> '(;; Basic tones
> @@ -246,7 +250,4 @@ represents."
>
> (provide-theme 'standard-light))
>
> -;;;###theme-autoload
> -(put 'standard-light 'theme-properties '(:background-mode light :kind
> color-scheme :family standard))
> -
> ;;; standard-light-theme.el ends here
- Re: [elpa] externals/standard-themes 0604883ecc: Expand 'deftheme' with metadata,
Philip Kaludercic <=