emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Eglot tests on EMBA


From: Michael Albinus
Subject: Re: Eglot tests on EMBA
Date: Fri, 31 Mar 2023 12:31:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

João Távora <joaotavora@gmail.com> writes:

Hi João,

> After reading the logs,  I think it comes down to how you installed
> pylsp on EMBA.   I think you should do it with
>
>    pip install "python-lsp-server[all]"
>
> which install its "providers", which are some type of contribs.

I'm not happy with this. EMBA installs a conservative list of software;
they shall be available as Debian bullseye package.

Since Debian bullseye does not offer the package python3-pylsp (which
will be available with a later Debian release), I install on EMBA
python3-pyls. This shall be sufficient, because (according to
eglot-server-programs) "pyls" is supported.

eglot-tests.el does not dertect this, it checks only for "pylsp". I
believe this shall be changed, the check shall be for all alternatives
configured in eglot-server-programs. And not only for python, but also
for other languages.

Because of this deficiency, I run "ln -s /usr/bin/pyls /usr/bin/pylsp"
on EMBA. But I dislike it.

> We could have code in eglot-tests.el to check if these "providers"
> are installed into pylsp, but I think it's better to just install
> pylsp like I provided, and start thinking of some other less
> problematic server for these tests.

Hmm, again, I don't believe we shall adapt everything just that the
tests run. It must be the other direction: eglot-tests must check the
environment, and do what's possible. You cannot always assume that
people are using bleeding edge software. It is a valid assumption, that
people use stable distributions, like Debian bullseye.

I have no idea what is needed internally, but Debian bullseye offers
also the packages

--8<---------------cut here---------------start------------->8---
Package python3-pyls-black
    bullseye (stable) (python): Black plugin for the Python Language Server
    0.4.6-3: all

Package python3-pyls-jsonrpc
    bullseye (stable) (python): Python server implementation of the JSON RPC 
2.0 protocol
    0.4.0-2: all

Package python3-pyls-spyder
    bullseye (stable) (python): Spyder plugin for the Python Language Server
    0.3.0-3: all
--8<---------------cut here---------------end--------------->8---

Is there something we shall install?

> Maybe move the test to clangd.  I think it would be equally
> valid.  But I've not made up my mind if Eglot tests should test
> a wide or narrow field of language servers.  Opinions welcome.

Your decision.

> João

Best regards, Michael.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]