Re: Eglot tests on EMBA

[João Távora]

Michael, eglot-test-multiline-eldoc doesn't fail locally for me (or
in the GitHub CI system (https://github.com/joaotavora/eglot/actions)
though that is not running master.

After reading the logs,  I think it comes down to how you installed
pylsp on EMBA.   I think you should do it with

   pip install "python-lsp-server[all]"

which install its "providers", which are some type of contribs.

We could have code in eglot-tests.el to check if these "providers"
are installed into pylsp, but I think it's better to just install
pylsp like I provided, and start thinking of some other less
problematic server for these tests.

Maybe move the test to clangd.  I think it would be equally
valid.  But I've not made up my mind if Eglot tests should test
a wide or narrow field of language servers.  Opinions welcome.

João

On Wed, Mar 29, 2023 at 3:46 PM João Távora <joaotavora@gmail.com> wrote:
>
> I can check the eldoc/eglot tests later, looks like I introduced it in a 
> recent commit and the test might need updating.
>
> João
>
> On Wed, Mar 29, 2023, 15:34 Michael Albinus <michael.albinus@gmx.de> wrote:
>>
>> Michael Albinus <michael.albinus@gmx.de> writes:
>>
>> Hi,
>>
>> > FTR, I have changed test/infra/Dockerfile.emba to install also clangd on
>> > the server. This shall enable some of the Eglot tests, which are skipped
>> > at all ATM. Pushed to the emacs-29 branch.
>>
>> This has been extended for the master branch. On EMBA, there are now two
>> jobs build-image-eglot and test-eglot, which run in every scheduled
>> pipeline for the master branch. See for example
>> <https://emba.gnu.org/emacs/emacs/-/jobs/65322> and
>> <https://emba.gnu.org/emacs/emacs/-/jobs/65324>. The result,
>> eglot-tests.log from the latter job, can be retrieved as artifact via
>> <https://emba.gnu.org/emacs/emacs/-/jobs/65324/artifacts/download>.
>>
>> While 36 (of 50) tests pass, we have also one failing and 13 skipped jobs:
>>
>> --8<---------------cut here---------------start------------->8---
>> Ran 50 tests, 36 results as expected, 1 unexpected, 13 skipped (2023-03-29 
>> 14:07:00+0000, 75.388590 sec)
>>
>> 1 unexpected results:
>>    FAILED  eglot-test-multiline-eldoc  "eglot--tests-force-full-eldoc didn't 
>> deliver"
>>
>> 13 skipped results:
>>   SKIPPED  eglot-test-eclipse-connect  ((skip-unless (executable-find 
>> "jdtls")) :form (executable-find "jdtls") :value nil)
>>   SKIPPED  eglot-test-javascript-basic  ((skip-unless (and (executable-find 
>> "typescript-language-server") (executable-find "tsserver"))) :form (and 
>> (executable-find "typescript-language-server") (executable-find "tsserver")) 
>> :value nil)
>>   SKIPPED  eglot-test-json-basic  ((skip-unless (executable-find 
>> "vscode-json-languageserver")) :form (executable-find 
>> "vscode-json-languageserver") :value nil)
>>   SKIPPED  eglot-test-path-to-uri-windows  ((skip-unless (eq system-type 
>> 'windows-nt)) :form (eq gnu/linux windows-nt) :value nil)
>>   SKIPPED  eglot-test-project-wide-diagnostics-rust-analyzer  ((skip-unless 
>> (executable-find "rust-analyzer")) :form (executable-find "rust-analyzer") 
>> :value nil)
>>   SKIPPED  eglot-test-project-wide-diagnostics-typescript  ((skip-unless 
>> (and (executable-find "typescript-language-server") (executable-find 
>> "tsserver"))) :form (and (executable-find "typescript-language-server") 
>> (executable-find "tsserver")) :value nil)
>>   SKIPPED  eglot-test-python-autopep-formatting  ((skip-unless (and 
>> (executable-find "pylsp") (executable-find "autopep8"))) :form (and 
>> (executable-find "pylsp") (executable-find "autopep8")) :value nil)
>>   SKIPPED  eglot-test-python-yapf-formatting  ((skip-unless (and 
>> (executable-find "pylsp") (not (executable-find "autopep8")) (or 
>> (executable-find "yapf") (executable-find "yapf3")))) :form (and 
>> (executable-find "pylsp") (not (executable-find "autopep8")) (or 
>> (executable-find "yapf") (executable-find "yapf3"))) :value nil)
>>   SKIPPED  eglot-test-rust-analyzer-hover-after-edit  ((skip-unless 
>> (executable-find "rust-analyzer")) :form (executable-find "rust-analyzer") 
>> :value nil)
>>   SKIPPED  eglot-test-rust-analyzer-watches-files  ((skip-unless 
>> (executable-find "rust-analyzer")) :form (executable-find "rust-analyzer") 
>> :value nil)
>>   SKIPPED  eglot-test-rust-on-type-formatting  ((skip-unless 
>> (executable-find "rust-analyzer")) :form (executable-find "rust-analyzer") 
>> :value nil)
>>   SKIPPED  eglot-test-snippet-completions  ((skip-unless (and 
>> (executable-find "pylsp") (functionp 'yas-minor-mode))) :form (and 
>> (executable-find "pylsp") (functionp 'yas-minor-mode)) :value nil)
>>   SKIPPED  eglot-test-snippet-completions-with-company  ((skip-unless (and 
>> (executable-find "pylsp") (functionp 'yas-minor-mode) (functionp 
>> 'company-complete))) :form (and (executable-find "pylsp") (functionp 
>> 'yas-minor-mode) (functionp 'company-complete)) :value nil)
>> --8<---------------cut here---------------end--------------->8---
>>
>> Could somebody check why the test eglot-test-multiline-eldoc fails? And
>> are there recipes how to install the missing dependencies in Debian
>> bullseye, in order to activate the missing tests? I've digged for
>> recipes of clangd and pylisp (see test/infra/Dockerfile.emba target
>> emacs-eglot); doing it for the other dependencies would be too much for
>> me.
>>
>> Best regards, Michael.



-- 
João Távora