Re: master 0724c6dbdae: Use string-search instead of string-match[-p] when possible

[Robert Pluim]

>>>>> On Wed, 29 Mar 2023 17:34:36 +0200, Mattias Engdegård <mattiase@acm.org> 
>>>>> said:

    Mattias> 29 mars 2023 kl. 17.23 skrev Robert Pluim <rpluim@gmail.com>:
    >> Hmm, we could do this using a compiler macro, no? Something like
    >> 
    >> (put 'string-match-p 'compiler-macro
    >> #'byte-optimize-string-match-p)

    Mattias> No, that would be incorrect: string-match-p obeys 
case-fold-search, string-search doesn't.

Right, Iʼd forgotten about that. And a warning would be a bit
intrusive, I think.

    Mattias> Replacing string-match[-p] with string-search in the source also 
makes the code clearer.

Thatʼs definitely true.

Robert
--