[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merging feature/android
From: |
Po Lu |
Subject: |
Re: Merging feature/android |
Date: |
Fri, 17 Mar 2023 19:27:24 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Arash Esbati <arash@gnu.org> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> That doesn't necessarily prove they are the same. Please compare the
>> values of WARN_CFLAGS in src/Makefile between the two branches.
>
> Thanks. This is from master (line breaks added manually):
>
> WARN_CFLAGS = -fno-common -Wall -Warith-conversion -Wdate-time
> -Wdisabled-optimization -Wdouble-promotion -Wduplicated-cond -Wextra
> -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op
> -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes
> -Wnested-externs -Wnull-dereference -Wold-style-definition -Wopenmp-simd
> -Wpacked -Wpointer-arith -Wstrict-prototypes
> -Wsuggest-attribute=noreturn -Wsuggest-final-methods
> -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas
> -Wunused-macros -Wvariadic-macros -Wvector-operation-performance
> -Wwrite-strings -Warray-bounds=2 -Wattribute-alias=2 -Wformat=2
> -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wshift-overflow=2
> -Wuse-after-free=3 -Wvla-larger-than=4031
> -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare
> -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral
> -Wno-bidi-chars -Wno-pointer-sign
>
> This is from feature/android:
>
> WARN_CFLAGS =
>
> And while looking at the diff:
>
> master uses the -isystem flag, feature branch uses -I, e.g.:
>
> WEBP_CFLAGS= -isystem C:/msys64/mingw64/include/webp (master)
> WEBP_CFLAGS= -IC:/msys64/mingw64/include/webp (feature/android)
>
> Best, Arash
I think I've fixed this now. Would you please test on MinGW to make
sure?
- Re: Merging feature/android, (continued)
- Re: Merging feature/android, Eli Zaretskii, 2023/03/16
- Re: Merging feature/android, Arash Esbati, 2023/03/16
- Re: Merging feature/android, Eli Zaretskii, 2023/03/16
- Re: Merging feature/android, Po Lu, 2023/03/16
- Re: Merging feature/android, Arash Esbati, 2023/03/16
- Re: Merging feature/android, Eli Zaretskii, 2023/03/16
- Re: Merging feature/android, Arash Esbati, 2023/03/16
- Re: Merging feature/android, Eli Zaretskii, 2023/03/16
- Re: Merging feature/android, Arash Esbati, 2023/03/17
- Re: Merging feature/android, Po Lu, 2023/03/17
- Re: Merging feature/android,
Po Lu <=
- Re: Merging feature/android, Arash Esbati, 2023/03/17
- Re: Merging feature/android, Po Lu, 2023/03/17
- Re: Merging feature/android, Arash Esbati, 2023/03/17
- Re: Merging feature/android, Corwin Brust, 2023/03/17