Re: Merging feature/android

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org, Paul Eggert <eggert@cs.ucla.edu>
> Date: Thu, 02 Mar 2023 18:19:50 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >  . The PATCH FOR LIBXML2 part and similar parts for patching other
> >    libraries and components should also be in separate files, suitable
> >    for submitting to Patch or similar utilities, and INSTALL should
> >    only mention the need for these patch and refer to those files.
> 
> What would be a good place to put these patch files? admin/notes
> perhaps?

In the same android/ subdirectory, I think.

> > -OPTION_DEFAULT_ON([modules],[don't compile with dynamic modules support])
> > +OPTION_DEFAULT_IFAVAILABLE([modules],[don't compile with dynamic modules 
> > support])
> >
> > Why was this changed to "ifavailable"?
> 
> Because the modules code has a dependency on the GCC cleanup function
> extension, and fails to compile when it is not present.  I rewrote the
> configury to detect the presence of the extension and not build with
> modules when that is in effect.

Rewriting the configury is OK, but that still doesn't need
ifavailable, AFAIU.  For example, we build with HarfBuzz if that is
available, but we don't use ifavailable for it.  How is this one
different?

> > The files in cross/lib/ seem to be from Gnulib?  If so, do we really
> > need another copy of them in the tree? any way to reuse the sources in
> > lib/ instead?
> 
> I tried multiple times, but the gnulib stuff kept trying to include
> generated headers from the wrong copy of gnulib, so in the end I
> couldn't find any way around having to keep two copies of gnulib
> in-tree.

What do you mean by "from the wrong copy"?  The two copies are
identical, no?  They are generated for the same platform, right?

In any case, before we include two copies, we should ask Gnulib folks
for help in this matter.