Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection

[Philip Kaludercic]

Protesilaos Stavrou <info@protesilaos.com> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Sat, 17 Sep 2022 10:40:32 +0000
>
>> [... 21 lines elided]
>
>>> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
>>> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
>>> +;; This duplication seems unnecessary.
>>>  (defconst ef-themes-collection
>>>    '(ef-autumn
>>>      ef-dark
>>
>> Is there any reason you couldn't just replace the definition with
>>
>>    (seq-union ef-themes-light-themes ef-themes-dark-themes)
>>
>> ?
>
> You mean to include that in the relevant functions and remove the
> 'ef-themes-collection' altogether?  

I was thinking of replacing the 

    '(ef-autumn
      ef-dark

with the `seq-union' call from above.

>                                     I was thinking that having a
> standalone variable is easier for documentation purposes.  Same for
> 'ef-themes-{dark,light}-themes'.
>
> Though yes, your code does what I want.