Re: [nongnu] elpa/xah-fly-keys b3746d9f81: xah-run-current-file fixed a critical bug in last commit

[Stefan Monnier]

> branch: elpa/xah-fly-keys
> commit b3746d9f81bb7a874b15b66de86ffd573b5762a6
> Author: Xah Lee <xah@xahlee.org>
> Commit: Xah Lee <xah@xahlee.org>
>
>     xah-run-current-file fixed a critical bug in last commit

Neither this description, nor the new code explain why the change
was made.  I recommend when you make such changes to add a comment in
the code explaining why the change was made (in the case, why
`shell-quote-argument` shouldn't be called on $progName).

Sometimes, the real reason is not well understood, but at least you can
put something like a description (or URL to it) of one case that is
otherwise broken.


        Stefan


> ---
>  xah-fly-keys.el | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xah-fly-keys.el b/xah-fly-keys.el
> index 28fe534161..0c284eee41 100644
> --- a/xah-fly-keys.el
> +++ b/xah-fly-keys.el
> @@ -4,7 +4,7 @@
>  
>  ;; Author: Xah Lee ( http://xahlee.info/ )
>  ;; Maintainer: Xah Lee <xah@xahlee.org>
> -;; Version: 18.0.20220911124616
> +;; Version: 18.0.20220916203045
>  ;; Created: 10 Sep 2013
>  ;; Package-Requires: ((emacs "24.1"))
>  ;; Keywords: convenience, emulations, vim, ergoemacs
> @@ -2465,7 +2465,7 @@ File suffix is used to determine which program to run, 
> set in the variable `xah-
>  If the file is modified or not saved, save it automatically before run.
>  
>  URL `http://xahlee.info/emacs/emacs/elisp_run_current_file.html'
> -Version: 2020-09-24 2022-05-16 2022-06-27 2022-08-12"
> +Version: 2020-09-24 2022-05-16 2022-06-27 2022-08-12 2022-09-16"
>    (interactive)
>    (setenv "NO_COLOR" "1") ; 2022-09-10 for deno. default color has yellow 
> parts, hard to see
>    (when (not buffer-file-name) (save-buffer))
> @@ -2484,7 +2484,7 @@ Version: 2020-09-24 2022-05-16 2022-06-27 2022-08-12"
>      (setq $cmdStr
>            (when $progName
>              (format "%s %s &"
> -                    (shell-quote-argument $progName)
> +                    $progName
>                      (shell-quote-argument $fname))))
>      (when (buffer-modified-p) (save-buffer))
>      (run-hooks 'xah-run-current-file-before-hook)