Re: GNU Emacs: A configurable browser

[Po Lu]

Anand Tamariya <atamariya@gmail.com> writes:

> https://lifeofpenguin.blogspot.com/2022/01/gnu-emacs-configurable-browser.html

I don't understand why you chose to describe the code in master as a
"competing implementation", if you want to work with us to have your
changes installed, which is what you proceed to say in your article.

I hope that you will improve your choice of words in the future, because
what you have said will result in many people misunderstanding the
nature of the code in master.

> https://gitlab.com/atamariya/emacs/-/blob/dev/src/xwidget.c

It would be much easier for me to review your changes if you based them
off a recent (in contrast with 10 months old) copy of master, and
submitted them in the form of a patch.

Most of the features which you posted are already available in
xwidget-webkit or other areas of Emacs, so I'm confused as to exactly
what changes you have made.  Judging by the code in your repository, you
also have remanants of many irrelevant features, such as support for
xembed.

Could you please explain exactly which changes you have made, remove
irrelevant features from your changes, rebase them onto master, and then
send them as a patch?

Thanks in advance.

> https://gitlab.com/atamariya/emacs/-/blob/dev/lisp/webkit/webkit-ace.el

This file is written by Akira Kyle, not by you, who has been active
around here lately.  Akira, have you signed the papers necessary for it
to be included in Emacs?

> https://gitlab.com/atamariya/emacs/-/blob/dev/etc/webkit/hints.js
> https://gitlab.com/atamariya/emacs/-/blob/dev/etc/webkit/hints.css

To the best of my knowledge, these two files are also written by Akira.