Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action'

[martin rudalics]

> IIRC I once used the term 'label' for it.  It vanished soon.

After trying to implement this idea I immediately started to dislike it
for technical reasons ('pop-to-buffer-same-window' never had an ACTION
argument so I had to invent some clumsy extra argument to make things
work).  I attach the diffs in case we still want to implement something
the like.

Otherwise, I think that harm has been done - 'pop-to-buffer-same-window'
was invented as stand-in for 'switch-to-buffer' and should never have
replaced 'pop-to-buffer' - but I missed that back then so I'm not in a
good position to ask for reverting that change now.

Sam's patch, although it does not restore the previous behavior, still
looks like the least obtrusive solution in this regard.  It's partially
a misnomer - to my knowledge at least 'eshell' has no connection to
"comint" - so we apparently cannot put 'display-comint-buffer-action'
into comint.el where it would belong.  Yet I'd tend to keep it, after
applying Morgan's fix from Bug#52878, obviously.

martin

display-buffer-label.diff
Description: Text Data