emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Duplicated outline-cycle binding, and problems with the new one


From: Stefan Monnier
Subject: Re: Duplicated outline-cycle binding, and problems with the new one
Date: Wed, 05 Jan 2022 14:21:59 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

> But diff-mode overrides this binding with diff-mode-shared-map
> where the TAB key is bound to diff-hunk-next, since
> minor-mode-overriding-map-alist takes priority over
> minor-mode-map-alist when diff-mode does this:

I see.  I knew using `minor-mode-overriding-map-alist` in `diff-mode.el`
this way was going to bite us sooner or later.

Maybe we should use a hook on `read-only-mode` to set/unset
a `diff-mode-read-only` variable so we can add the keymap
(conditionalized on this new `diff-mode-read-only`) to
`minor-mode-map-alist` instead of `minor-mode-overriding-map-alist`.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]