emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of


From: Robert Pluim
Subject: Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
Date: Tue, 04 Jan 2022 16:44:55 +0100

>>>>> On Tue, 04 Jan 2022 16:57:16 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Eli Zaretskii <eliz@gnu.org>
    >> Date: Tue, 04 Jan 2022 14:25:32 +0100
    >> 
    Eli> -The key strokes are separated by a space character.
    Eli> +The key strokes are separated by space characters.
    >> 
    >> This is ambiguous now.
    >> 
    ELISP> (key-valid-p "a")
    >> t
    ELISP> (key-valid-p "a b")
    >> t
    ELISP> (key-valid-p "a  b")
    >> nil
    >> 
    >> Either we say 'single spaces', or we set OMIT-NULLS to t in the call
    >> to `split-string' inside `key-valid-p'.

    Eli> Feel free to improve ambiguous wording, no discussion is needed.

I asked because we had a looooong discussion about this back in
November with no clear outcome, except that the code now only allows 1
space :-)

Done as a0263cfee3

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]