Re: [nongnu] elpa/rainbow-delimiters a32b39bdfe: Add license file with GPLv3

[Philip Kaludercic]

Stefan Kangas <stefan@marxist.se> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> How about adding the files "LICENSE", "LICENSE.md" and "COPYING" to a
>> global ignore list instead?  (Those three being the variations I have
>> seen so far.)
>
> IOW, how about something like this (untested)?  I think there are some
> other files that we could always exclude as well, like ".dir-locals.el",
> ".github", "*-tests.el", and ".travis.yml".

Not sure about .dir-locals.el (the developers might be using the special
kind of indentation set via .dir-locals.el), but next to these I'd also
suggest removing "Cask" and "Makefile".

And while we are at it, is there a reason not to add a MELPA-like
keyword to manually specify what files are part of a package?  Whenever
a single repository is used to maintain multiple packages (like Magit or
Embark) there is always a long list of :ignored-files that have to be
duplicated for every package.  Perhaps a more general version of
.elpaignore could be used to declare packages externally.

> diff --git a/elpa-admin.el b/elpa-admin.el
> index b4ad318ef..37b3112dd 100644
> --- a/elpa-admin.el
> +++ b/elpa-admin.el
> @@ -562,6 +562,10 @@ auxillary files unless TARBALL-ONLY is non-nil ."
>                     "######## Build of package %s FAILED!!")
>                   tarball)))))
>
> +(defvar elpaa--make-tarball-global-ignore
> +  '("COPYING" "LICENSE" "LICENSE.md")
> +  "List of files that will not be included in the tarball.")
> +
>  (defun elpaa--make-one-tarball-1 ( tarball dir pkg-spec metadata
>                                   &optional revision-function tarball-only)
>    (elpaa--with-temp-files
> @@ -572,7 +576,8 @@ auxillary files unless TARBALL-ONLY is non-nil ."
>                 (make-directory destdir)))
>            (vers (nth 1 metadata))
>            (elpaignore (expand-file-name ".elpaignore" dir))
> -          (ignores (elpaa--spec-get pkg-spec :ignored-files))
> +          (ignores (append (elpaa--spec-get pkg-spec :ignored-files)
> +                           elpaa--make-tarball-global-ignore))
>            (renames (elpaa--spec-get pkg-spec :renames))
>            (ldir    (elpaa--spec-get pkg-spec :lisp-dir))
>            (re (concat "\\`" (regexp-quote pkgname)
>
>

-- 
        Philip Kaludercic